Conversation
There was a problem hiding this comment.
Thanks for this! A few things to address before merging:
Screenshots scope
All 5 screenshots are from the desktop app, but the text references both desktop and mobile in several places ("Desktop and Mobile apps", "desktop only" for expiration, the "+" button, whitelisting links for both). If this guide covers both platforms, we need mobile screenshots too. If it's desktop-only, that's fine — but we should remove the mobile references and create a separate mobile guide later.
UI label mismatches (comparing text vs desktop screenshots)
- "P2P Swap button" → the UI shows a Swap tab, not a "P2P Swap" button
- "Send" → UI label is Sending
- "Address" → UI label is Receiver address
- "Receive" → UI label is Receiving
Other fixes
- "On going swap" (last image caption) → Ongoing swap
- Step 2 in Accept section: "Select Confirm Swap or Accept Swap" — the desktop UI only shows Confirm Swap. If "Accept Swap" is the mobile label, clarify that.
- After accepting a proposal, add a sentence about what happens next (the swap processes on-chain and you'll see a "Blocks to unlock" progress indicator as shown in screenshot 2.7.2)
- Consider mentioning the Copy button on the hex code screen (screenshot 2.7.4)
Let me know if this is meant to be desktop+mobile or desktop-only and we'll go from there.
Address PR review feedback: remove mobile references, correct UI labels to match desktop app (Swap tab, Sending, Receiver address, Receiving), fix Ongoing swap caption, clarify Confirm Swap flow, mention Copy button, and add post-acceptance on-chain processing context. https://claude.ai/code/session_01RKDSJY8V9SgppQxJDWMhQL
Make Ionic Swap guide desktop-only and fix UI labels
|
Yes the guide was intended to cover mobile and desktop, it's desktop only now. Btw, on Mobile this feature is called P2P Swap, I think it should be called like that on Desktop as well. For now, I'll use the Desktop name in the guide. |
3 participants
No description provided.